Skip to content

Use WNetGetUniversalNameW instead of net use#1284

Open
alanhamlett wants to merge 1 commit intodevelopfrom
feature/replace-net-use
Open

Use WNetGetUniversalNameW instead of net use#1284
alanhamlett wants to merge 1 commit intodevelopfrom
feature/replace-net-use

Conversation

@alanhamlett
Copy link
Member

More reliable than parsing output from net use, which might not always output English language.

@alanhamlett alanhamlett requested a review from gandarez March 24, 2026 01:30
@alanhamlett alanhamlett force-pushed the feature/replace-net-use branch from b6a263c to 5dcaf5e Compare March 24, 2026 13:39
@codecov
Copy link

codecov bot commented Mar 24, 2026

Codecov Report

❌ Patch coverage is 50.00000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 53.25%. Comparing base (e932c38) to head (5dcaf5e).

Files with missing lines Patch % Lines
pkg/windows/windows_api_stub.go 0.00% 6 Missing ⚠️
@@             Coverage Diff             @@
##           develop    #1284      +/-   ##
===========================================
- Coverage    53.43%   53.25%   -0.18%     
===========================================
  Files          394      395       +1     
  Lines        11606    11536      -70     
===========================================
- Hits          6202     6144      -58     
+ Misses        4855     4850       -5     
+ Partials       549      542       -7     
Flag Coverage Δ
unittests 53.25% <50.00%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
pkg/windows/windows.go 94.73% <100.00%> (+12.28%) ⬆️
pkg/windows/windows_api_stub.go 0.00% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant