add support for queueing ActiveJob jobs#696
Open
josh-m-sharpe wants to merge 1 commit intoresque:masterfrom
Open
add support for queueing ActiveJob jobs#696josh-m-sharpe wants to merge 1 commit intoresque:masterfrom
josh-m-sharpe wants to merge 1 commit intoresque:masterfrom
Conversation
iloveitaly
requested changes
Oct 18, 2021
Contributor
iloveitaly
left a comment
iloveitaly
left a comment
There was a problem hiding this comment.
This is awesome addition. Could you make a couple quick tweaks:
- Add this to the changelog
- Rebase on master and ensure CI runs
- Quick documentation change requested
| if klass.respond_to?(:scheduled) | ||
| klass.scheduled(queue, klass_name, *params) | ||
| elsif klass.respond_to?(:perform_later) | ||
| klass.set(queue: queue).perform_later(*params) |
Contributor
There was a problem hiding this comment.
Could you add a one-line comment here about what is code is doing? Even just linking to this PR would be helpful for the future reader.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows resque scheduler to set the queue correctly for ActiveJobs when resque schedule's YAML configuration does not set the queue. Depends on this resque PR: resque/resque#1713