fix: pendulum.parse('2007-12-13/14:30') raised TypeError instead of uniform ValueError#954
Open
alexanderlukanin13 wants to merge 1 commit intopython-pendulum:masterfrom
Open
Conversation
…niform ValueError Time object was falling through type checks in Interval.__new__
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When trying to parse non-standard Interval format mixing date/datetime and time (both individually valid), error message is inconsistent because
Timeis falling through unchecked.Behavior in 3.2.0:
After fix the exception is uniform in all cases:
Note: format
2007-12-13T14:30/15:45is allowed in some lenient ISO 8601 implementations (e.g. aniso8601 package). I believe it's a good thing that pendulum does not allow it because it's ambiguous.