fix: handle assignref in needsParens like assign#2465
Draft
jorgsowa wants to merge 1 commit intoprettier:mainfrom
Draft
fix: handle assignref in needsParens like assign#2465jorgsowa wants to merge 1 commit intoprettier:mainfrom
jorgsowa wants to merge 1 commit intoprettier:mainfrom
Conversation
jorgsowa
force-pushed
the
fix/assignref-missing-in-needs-parens
branch
from
6a136b4 to
420d7d6
Compare
assignref was missing from the needsParens switch, falling through to return false. This caused parens to be dropped in contexts where they change semantics, e.g. $a = ($b =& $var) + 5 became $a = $b = &$var + 5.
jorgsowa
force-pushed
the
fix/assignref-missing-in-needs-parens
branch
from
420d7d6 to
86ce94e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
assignrefwas missing from the needsParens switch, falling through to return false. This caused parens to be dropped in contexts where they change semantics, e.g.$a = ($b =& $var) + 5became$a = $b = &$var + 5.