Skip to content

feat(Wizard): added plain styling#12289

Open
thatblindgeye wants to merge 2 commits intopatternfly:mainfrom
thatblindgeye:iss12277_wizardPlain
Open

feat(Wizard): added plain styling#12289
thatblindgeye wants to merge 2 commits intopatternfly:mainfrom
thatblindgeye:iss12277_wizardPlain

Conversation

@thatblindgeye
Copy link
Contributor

@thatblindgeye thatblindgeye commented Mar 24, 2026

What: Closes #12277

Additional issues:

Summary by CodeRabbit

  • New Features

    • Wizard component gains two optional styling flags to enable a plain appearance and to control plain styling when displayed on glass surfaces.
  • Tests

    • Added tests to ensure the new styling flags apply the correct visual modifiers.
  • Documentation

    • Added a "Plain" Wizard example and updated example docs demonstrating the new styling options.

@thatblindgeye thatblindgeye requested review from kmcfaul and mcoker March 24, 2026 17:37
@coderabbitai
Copy link

coderabbitai bot commented Mar 24, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 57ec75ef-adf9-4071-b318-034109546ec4

📥 Commits

Reviewing files that changed from the base of the PR and between 1d13c2d and 85a7c1b.

📒 Files selected for processing (1)
  • packages/react-core/src/components/Wizard/Wizard.tsx
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/react-core/src/components/Wizard/Wizard.tsx

Walkthrough

Adds two optional props, isPlain and isNoPlainOnGlass, to the Wizard component to conditionally apply .pf-m-plain and .pf-m-no-plain modifier classes; includes tests, documentation entry, and a new example demonstrating the plain wizard styling.

Changes

Cohort / File(s) Summary
Core Component Implementation
packages/react-core/src/components/Wizard/Wizard.tsx
Added optional isPlain?: boolean and isNoPlainOnGlass?: boolean to WizardProps. Updated prop destructuring and root <div> className to include styles.modifiers.plain when isPlain is true and styles.modifiers.noPlain when isNoPlainOnGlass is true.
Component Tests
packages/react-core/src/components/Wizard/__tests__/Wizard.test.tsx
Added two tests asserting the presence of pf-m-plain when isPlain is set and pf-m-no-plain when isNoPlainOnGlass is set.
Documentation & Examples
packages/react-core/src/components/Wizard/examples/Wizard.md, packages/react-core/src/components/Wizard/examples/WizardPlain.tsx
Added a "Plain" example entry and a new WizardPlain example component demonstrating a plain-styled Wizard with three steps and footer config.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

  • dlabaj
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Linked Issues check ⚠️ Warning The PR implements most requirements but uses isNoPlainOnGlass instead of isNoPlain, and the property naming inconsistency may cause confusion. Verify that isNoPlainOnGlass is the correct property name per design specification, or rename it to isNoPlain for consistency with the issue requirements [#12277].
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly and concisely describes the main change: adding plain styling support to the Wizard component.
Out of Scope Changes check ✅ Passed All changes are directly aligned with the linked issue requirements: props implementation, test coverage, documentation example, and TypeScript types.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@patternfly-build
Copy link
Collaborator

patternfly-build commented Mar 24, 2026

*/
shouldFocusContent?: boolean;
/** Adds plain styling to the wizard. */
isPlain?: boolean;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious, does this prop do nothing? Or are style changes applied with pf-m-plain. I ask because it is hard coded below so I am assuming it has no styles associated with it.
If the prop does not do anything, do we need to add it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This prop will dictate whether the pf-m-plain class is applied

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add plain styling support to Wizard component

3 participants