Remove default ingress annotation from helm chart so that ingressClassName is settable in wrapped chart#1100
Conversation
|
Thank you for your contribution. It seems that one or more of your commits have a "Signed-off-by" statement with an anonymous email address. The Developer Certificate of Origin (DCO) requires all commits to be signed off by genuine, contactable individuals. Please see our contributing guide. This will only take a few moments. First, clone your fork and checkout this branch using the git CLI. Next, set up your real name and email address:
Finally, run one of these commands to add the "Signed-off-by" line to your commits. If you only have one commit so far then run: Check that the message has been added properly by running "git log". |
Signed-off-by: Richard Lavey <[email protected]>
55e451d to
eb0f4bb
Compare
Description
Remove the default ingress annotation that defaults to nginx. ingressClassName is the correct way to set the ingress.
Why is this needed?
Fixes #1000
When the chart is wrapped inside another it is not possible to unset the ingress annotation (see helm/helm/issues/9027). This means that if
ingress.ingressClassNameis set the deployment fails due to the annotation also being present.Who is this for?
We are StructureFlow.
How Has This Been Tested?
I've successfully deployed my local change to a local cluster with the ingress enabled and
ingressClassName: nginxTypes of changes
Checklist:
git commit -s