This repository was archived by the owner on Mar 7, 2020. It is now read-only.
Fixes #7 giving function dev the ability to handle OPTIONS CORS headers#9
Open
petecj2 wants to merge 1 commit intoopenfaas-incubator:masterfrom
Open
Fixes #7 giving function dev the ability to handle OPTIONS CORS headers#9petecj2 wants to merge 1 commit intoopenfaas-incubator:masterfrom
petecj2 wants to merge 1 commit intoopenfaas-incubator:masterfrom
Conversation
…o branch off of event.method value and handle OPTIONS CORS headers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simple two line fix that enables the function developer to write to the response headers for the OPTIONS verb in the same way they already could for GET and POST. They can now branch in function code on
event.methodfor OPTIONS and handle CORS headers as they see fit.