This repository was archived by the owner on Jun 18, 2020. It is now read-only.
Open
Conversation
|
Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide. |
rimiti
reviewed
Jul 27, 2019
| const handler = require('./function/handler'); | ||
| const bodyParser = require('body-parser') | ||
|
|
||
| const cors = require("cors");// imported cors package |
rimiti
reviewed
Jul 27, 2019
| app.patch('/*', middleware); | ||
| app.use(cors());// enabled cors | ||
| app.put('/*', middleware); | ||
| app.use(cors());// enabled cors |
There was a problem hiding this comment.
You could use an instance Router instead of duplicating app.use(cors());
rimiti
reviewed
Jul 27, 2019
| app.patch('/*', middleware); | ||
| app.use(cors());// enabled cors | ||
| app.put('/*', middleware); | ||
| app.use(cors());// enabled cors |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I was creating a short URL service with openfaas , while integrating the function with react js front end, It showed
. so I edited the templates which enable cors and it worked fine, so I thought it would be a good feature to add to the templates