[WIP] Fix fail method

[kturcios]

The following PR will fix an issue where context.fail() did not return custom status codes even though context.status() was called.

Description

I modified the context.succeed() and context.fail() methods to return a default status code of 200 and 500, respectively.

When the callback method (cb) is invoked, it will check which status code to return by checking if it has been defined by the handler (i.e. this.statusCode !== undefined). Otherwise, it will return the default status code mentioned above.

Motivation and Context

• I have raised an issue to propose this change (required)

Which issue(s) this PR fixes

Fixes #4

How Has This Been Tested?

I created a handler with the following snippet and got the expected status code and message.

module.exports = (event, context) => {
    context
        .status(501)
        .fail('An error occurred');
}

Types of changes

• Bug fix (non-breaking change which fixes an issue)

Checklist:

• My code follows the code style of this project.
• I've read the CONTRIBUTION guide
• I have signed-off my commits with git commit -s

[tuct]

+1 for this one, I ended up using the succeed function for fail to be able to set the status code according to my needs.

Also I had to modify the template later in order to enable gzip, might create a pr soon which will expose express app for that purpose to the Handler on init only (this would also allow other tweaks to the express app).

[alexellis]

I'm wondering if we should package a small unit test using mocha and a dev dependency?

[alexellis]

👋 @tuct

👇 ?

Join Slack to connect with the community
https://docs.openfaas.com