Skip to content

stac: use datacube's ds2stac#1062

Draft
pjonsson wants to merge 2 commits intoopendatacube:developfrom
pjonsson:stac-convert-dataset
Draft

stac: use datacube's ds2stac#1062
pjonsson wants to merge 2 commits intoopendatacube:developfrom
pjonsson:stac-convert-dataset

Conversation

@pjonsson
Copy link
Contributor

@pjonsson pjonsson commented Mar 18, 2026

Replace the old EO3->STAC conversion
code with a call into datacube instead.


📚 Documentation preview 📚: https://datacube-explorer--1062.org.readthedocs.build/en/1062/

@codecov
Copy link

codecov bot commented Mar 18, 2026

Codecov Report

❌ Patch coverage is 12.50000% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.10%. Comparing base (2c753e2) to head (c5eae23).

Files with missing lines Patch % Lines
cubedash/_stac.py 12.50% 7 Missing ⚠️

❌ Your project check has failed because the head coverage (70.10%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

❗ There is a different number of reports uploaded between BASE (2c753e2) and HEAD (c5eae23). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (2c753e2) HEAD (c5eae23)
4 2
Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #1062       +/-   ##
============================================
- Coverage    83.95%   70.10%   -13.86%     
============================================
  Files           35       35               
  Lines         4295     4288        -7     
  Branches       540      536        -4     
============================================
- Hits          3606     3006      -600     
- Misses         493     1117      +624     
+ Partials       196      165       -31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pjonsson pjonsson force-pushed the stac-convert-dataset branch 2 times, most recently from 1fab7f6 to abeb33e Compare March 18, 2026 12:02
The STAC organization have reorganized,
so download the extensions from
the new place.

Also add some new extensions that
will be required when using stac2ds
from datacube-core in the future.
Replace the old EO3->STAC conversion
code with a call into datacube instead.
@pjonsson pjonsson force-pushed the stac-convert-dataset branch from abeb33e to c5eae23 Compare March 18, 2026 12:54
@pjonsson pjonsson marked this pull request as draft March 18, 2026 14:37
@pjonsson
Copy link
Contributor Author

This makes the test emit a raw None in the STAC output for nodata value for some raster bands, so putting this in draft for now.

I think the issue will be fixed by opendatacube/datacube-core#2402.

@Ariana-B
Copy link
Contributor

This is a little awkward - I was previously working on this same update but for some reason never pushed up the branch.
Since there are some differences in our implementations, I've made it a draft PR so we can compare and consolidate: #1065

@pjonsson
Copy link
Contributor Author

Well, I don't know what I'm doing in these areas and the PR isn't working so I don't have any particular fondness of keeping this branch. Can you approve #1061 so we get the simple changes merged to start with, and then we work from there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants