fix: correct prompt_cache_retention literal type from "in-memory" to "in_memory"#3003
Open
alvinttang wants to merge 1 commit intoopenai:mainfrom
Open
fix: correct prompt_cache_retention literal type from "in-memory" to "in_memory"#3003alvinttang wants to merge 1 commit intoopenai:mainfrom
alvinttang wants to merge 1 commit intoopenai:mainfrom
Conversation
The Literal type for `prompt_cache_retention` used "in-memory" (hyphen) but the OpenAI API expects "in_memory" (underscore), causing 400 errors. Fixes openai#2883 Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2883.
The
prompt_cache_retentionparameter type declaration used"in-memory"(hyphen) as a validLiteralvalue, but the OpenAI API expects"in_memory"(underscore). Passing"in-memory"results in a400error from the API.Changes
src/openai/types/chat/completion_create_params.py—Literal["in-memory", "24h"]→Literal["in_memory", "24h"]src/openai/types/responses/response_create_params.py— same fixsrc/openai/types/responses/response.py— same fixsrc/openai/types/responses/responses_client_event_param.py— same fixsrc/openai/types/responses/responses_client_event.py— same fixsrc/openai/resources/responses/responses.py— all overloads updatedsrc/openai/resources/chat/completions/completions.py— all overloads updatedtests/api_resources/test_responses.py— test values updated to matchtests/api_resources/chat/test_completions.py— test values updated to matchReproduction
🤖 Generated with Claude Code