docs(plans): full project review and APS work item tracking#13
docs(plans): full project review and APS work item tracking#13joshuaboys merged 1 commit intomainfrom
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fe80ef0b26
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Pull request overview
Adds a comprehensive project review document and updates APS planning artifacts to reflect the review findings and current project status (especially around MCP progress and new prioritized work items).
Changes:
- Introduces
plans/reviews-omo-review.mdwith an architecture/test/CI/plan-accuracy review and prioritized recommendations. - Adds new APS work items to core/cli plans (CORE-014..020, CLI-013..015) derived from the review.
- Updates milestone/module status tracking in the APS index and marks MCP-001 as complete.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| plans/reviews-omo-review.md | New review write-up covering architecture, quality, test coverage, CI/CD, and APS accuracy. |
| plans/index.aps.md | Updates M6 MCP milestone status and resequences the “What’s Next” queue with priorities. |
| plans/modules/distil-core.aps.md | Adds CORE-014..020 work items to track refactors/tests/docs from the review. |
| plans/modules/distil-cli.aps.md | Adds CLI-013..015 work items (command tests, command extraction, empty-catch fix). |
| plans/modules/distil-mcp.aps.md | Updates MCP module status and marks MCP-001 as complete with a completion note. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Reconcile MCP completion status: mark MCP-002, MCP-003, MCP-004 as complete in module plan and index. Fix dependency versions (tree-sitter ^0.22.4, MCP SDK ^1.12.1), CI pipeline description (Node 20+22, no lint step), and milestone numbering table to match canonical index. Clarify M2 Kindling integration as scaffolded-not-wired.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d9e5765bb7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| | 2 | CORE-014 | [core](modules/distil-core.aps.md) | core | @aneki | Ready | P1 | | ||
| | 3 | CORE-015 | [core](modules/distil-core.aps.md) | core | @aneki | Ready | P1 | | ||
| | 4 | CORE-016 | [core](modules/distil-core.aps.md) | core | @aneki | Ready | P1 | | ||
| | 5 | CORE-021 | [core](modules/distil-core.aps.md) | core | @aneki | Ready | P1 | |
There was a problem hiding this comment.
This queue entry introduces CORE-021 as ready work, but there is no corresponding CORE-021 task in plans/modules/distil-core.aps.md (the module task list ends at CORE-020 in this commit). That leaves the top-level roadmap pointing to an undefined item, so readers cannot find scope, dependencies, or validation details for a prioritized P1 task.
Useful? React with 👍 / 👎.
Reconcile MCP completion status: mark MCP-002, MCP-003, MCP-004 as complete in module plan and index. Fix dependency versions (tree-sitter ^0.22.4, MCP SDK ^1.12.1), CI pipeline description (Node 20+22, no lint step), and milestone numbering table to match canonical index. Clarify M2 Kindling integration as scaffolded-not-wired.
joshuaboys
force-pushed
the
docs/omo-project-review
branch
from
d9e5765 to
0e1bd85
Compare
There was a problem hiding this comment.
💡 Codex Review
distil/plans/reviews-omo-review.md
Line 24 in 0e1bd85
Remove unresolved conflict markers from review doc
This review document was committed with unresolved merge markers in the health dashboard/CI sections, which leaves mutually inconsistent statements (for example, conflicting CI matrix and lint-step descriptions) in the same artifact. That makes the audit unreliable for downstream planning because readers cannot tell which branch content is authoritative.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| | 2 | CORE-014 | [core](modules/distil-core.aps.md) | core | @aneki | Ready | P1 | | ||
| | 3 | CORE-015 | [core](modules/distil-core.aps.md) | core | @aneki | Ready | P1 | | ||
| | 4 | CORE-016 | [core](modules/distil-core.aps.md) | core | @aneki | Ready | P1 | | ||
| <<<<<<< HEAD |
There was a problem hiding this comment.
The What's Next table still includes raw conflict markers (<<<<<<<, |||||||, =======, >>>>>>>) and both sides of the merge, so the roadmap now contains contradictory queue entries and statuses in one document. This breaks the APS file as a single source of truth for prioritization and can mislead any planning/reporting step that reads this table.
Useful? React with 👍 / 👎.
Summary
plans/reviews-omo-review.mdcovering architecture, code quality, test coverage, CI/CD, and APS plan accuracyReview Highlights
findCallers()duplicated in CLI + MCP,BUILTIN_METHODSmisplaced in CLIFiles Changed
plans/reviews-omo-review.md— New review document (397 lines)plans/index.aps.md— Updated milestones, resequenced What's Next queueplans/modules/distil-core.aps.md— 7 new tasks (CORE-014..020)plans/modules/distil-cli.aps.md— 3 new tasks (CLI-013..015)plans/modules/distil-mcp.aps.md— MCP-001 status → Complete