Conversation
Updating to include contribution guidelines pertaining to AI generated fixes.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds contribution guidelines for changes prepared using AI tools to CONTRIBUTING.md. The new section is clear and sets reasonable expectations for contributors. I have one suggestion to clarify the testing requirements to ensure that contributions do not inadvertently break existing tests.
| 2. You must ensure that uploaded code compiles and passes at least the tests you have yourself | ||
| added as part of the change. |
There was a problem hiding this comment.
The requirement for testing could be stronger. Stating that the code must pass 'at least the tests you have yourself added' might be misinterpreted as allowing regressions in existing tests. To avoid ambiguity, it would be better to require that all relevant tests pass.
| 2. You must ensure that uploaded code compiles and passes at least the tests you have yourself | |
| added as part of the change. | |
| 2. You must ensure that uploaded code compiles and passes all relevant tests. |
There was a problem hiding this comment.
I love where this is going. Without digging too deep, I wonder if we couldn't all converge on what @elliette landed for devtools w/ flutter/devtools#9700? It'd be nice to have one consistent set of guidance.
2 participants
Updating to include contribution guidelines pertaining to AI generated fixes.
We want to ensure that our community is properly guided on our expectations around AI generated contributions.