Open
Conversation
…med parameters Tests: Add tests to cover new feature with backward compatibility
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the changes / Why this is an improvement
Adds client-side named parameter support (
pyformatparamstyle) to the CrateDB Python client, addressing the request in #774.Previously,
cursor.execute()only accepted positional?placeholders. Users with complex SQL had to maintain a positional list that was error-prone and hard to read.With this change, a
dictcan be passed as theparametersargument using%(name)splaceholders:The same parameter name may appear multiple times in the query, each occurrence is resolved independently:
Positional
?queries continue to work unchanged, no breaking change.Known limitation
Supporting named params in bulk operations are not supported because it requires a different approach from execute(). We need to extract the ordered parameter name list from the SQL. Excluded from this PR to keep this PR focused on the core execute() case.
Checklist