Skip to content

feat: Secure OAuth callback handling#653

Merged
arjankowski merged 1 commit intomainfrom
SDK-5808
Mar 24, 2026
Merged

feat: Secure OAuth callback handling#653
arjankowski merged 1 commit intomainfrom
SDK-5808

Conversation

@arjankowski
Copy link
Contributor

This PR improves OAuth callback handling in the login command and makes related tests more stable.

  • bind callback server to loopback and keep startup error handling clear (including busy port)
  • add timeout-based callback lifecycle completion to avoid hanging sessions
  • keep callback handling single-use by rejecting replayed requests
  • Simplify and stabilize login callback tests

@arjankowski arjankowski requested a review from a team March 24, 2026 11:41
@coveralls
Copy link

Pull Request Test Coverage Report for Build 23487624242

Details

  • 43 of 54 (79.63%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.9%) to 84.883%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/commands/login.js 43 54 79.63%
Files with Coverage Reduction New Missed Lines %
src/commands/login.js 1 60.59%
Totals Coverage Status
Change from base Build 23444664845: 0.9%
Covered Lines: 5064
Relevant Lines: 5707

💛 - Coveralls

Copy link
Collaborator

@Pask423 Pask423 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@arjankowski arjankowski merged commit 307d181 into main Mar 24, 2026
17 checks passed
@arjankowski arjankowski deleted the SDK-5808 branch March 24, 2026 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants