add length validation for Lock-Token to prevent underflow#618
Open
metsw24-max wants to merge 1 commit intoapache:trunkfrom
Open
add length validation for Lock-Token to prevent underflow#618metsw24-max wants to merge 1 commit intoapache:trunkfrom
metsw24-max wants to merge 1 commit intoapache:trunkfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change improves the handling of the Lock-Token request header in mod_dav by adding proper length validation before performing string indexing and trimming operations
The existing implementation processes the
Lock-Tokenheader without verifying that the string length is sufficient before-Accessing
lock_token_hdr[len - 1]-Computing
len - 2forapr_pstrndup