Skip to content

GH-49566: [Python] Skip header files when installing compiled Cython files#49571

Open
AlenkaF wants to merge 11 commits intoapache:mainfrom
AlenkaF:gh-49566-cython-headers
Open

GH-49566: [Python] Skip header files when installing compiled Cython files#49571
AlenkaF wants to merge 11 commits intoapache:mainfrom
AlenkaF:gh-49566-cython-headers

Conversation

@AlenkaF
Copy link
Member

@AlenkaF AlenkaF commented Mar 20, 2026

Rationale for this change

Local import is broken when doing editable install with scikit-build-core, also nightly verification jobs are failing for the same reason.

What changes are included in this PR?

lib.h and lib_api.h are already installed separately so we skip them when installing Cython extensions into the output destination (side-packages/pyarrow).

Are these changes tested?

Yes, locally and via the extended verification builds.

Are there any user-facing changes?

No.

@AlenkaF AlenkaF requested review from raulcd and rok as code owners March 20, 2026 10:20
@github-actions
Copy link

⚠️ GitHub issue #49566 has been automatically assigned in GitHub to PR creator.

@AlenkaF
Copy link
Member Author

AlenkaF commented Mar 20, 2026

@github-actions crossbow submit verify-rc-source-python-*

@github-actions
Copy link

Revision: 719eaf2

Submitted crossbow builds: ursacomputing/crossbow @ actions-3593c891fd

Task Status
verify-rc-source-python-linux-almalinux-10-amd64 GitHub Actions
verify-rc-source-python-linux-conda-latest-amd64 GitHub Actions
verify-rc-source-python-linux-ubuntu-22.04-amd64 GitHub Actions
verify-rc-source-python-linux-ubuntu-24.04-amd64 GitHub Actions
verify-rc-source-python-macos-amd64 GitHub Actions
verify-rc-source-python-macos-arm64 GitHub Actions
verify-rc-source-python-macos-conda-amd64 GitHub Actions

@raulcd
Copy link
Member

raulcd commented Mar 20, 2026

macOS failure are unrelated, I am trying to find a fix, the issue tracking them is this one:

@AlenkaF
Copy link
Member Author

AlenkaF commented Mar 20, 2026

We have a different issue now:

_____________________________ test_pyarrow_include _____________________________

    def test_pyarrow_include():
        # We need to make sure that pyarrow/include is always
        # created. Either with PyArrow C++ header files or with
        # Arrow C++ and PyArrow C++ header files together
    
        source = os.path.dirname(os.path.abspath(__file__))
        pyarrow_dir = pjoin(source, '..')
        pyarrow_include = pjoin(pyarrow_dir, 'include')
        pyarrow_cpp_include = pjoin(pyarrow_include, 'arrow', 'python')
    
>       assert os.path.exists(pyarrow_include)
E       AssertionError: assert False
E        +  where False = <function exists at 0x7ff433ef9e80>('/arrow/python/pyarrow/tests/../include')
E        +    where <function exists at 0x7ff433ef9e80> = <module 'posixpath' (frozen)>.exists
E        +      where <module 'posixpath' (frozen)> = os.path

Investigating ...

@AlenkaF
Copy link
Member Author

AlenkaF commented Mar 20, 2026

@raulcd I have updated the failing test as it was still checking the old location of the include folder which now moved to the site-packages. What do you think? The commit: 9ba4a76

@AlenkaF
Copy link
Member Author

AlenkaF commented Mar 20, 2026

@github-actions crossbow submit verify-rc-source-python-*

@github-actions
Copy link

Revision: 9ba4a76

Submitted crossbow builds: ursacomputing/crossbow @ actions-7e817c381a

Task Status
verify-rc-source-python-linux-almalinux-10-amd64 GitHub Actions
verify-rc-source-python-linux-conda-latest-amd64 GitHub Actions
verify-rc-source-python-linux-ubuntu-22.04-amd64 GitHub Actions
verify-rc-source-python-linux-ubuntu-24.04-amd64 GitHub Actions
verify-rc-source-python-macos-amd64 GitHub Actions
verify-rc-source-python-macos-arm64 GitHub Actions
verify-rc-source-python-macos-conda-amd64 GitHub Actions

@AlenkaF
Copy link
Member Author

AlenkaF commented Mar 20, 2026

Another issue I need to investigate:

arrow/dev/release/verify-release-candidate.sh: line 537: 94675 Bus error: 10              python -c "import pyarrow.flight"

@AlenkaF
Copy link
Member Author

AlenkaF commented Mar 20, 2026

@github-actions crossbow submit verify-rc-source-python-macos-arm64

@AlenkaF
Copy link
Member Author

AlenkaF commented Mar 20, 2026

Testing if it is a flaky macos issue ...

@github-actions
Copy link

Revision: 9ba4a76

Submitted crossbow builds: ursacomputing/crossbow @ actions-49b32e9b3a

Task Status
verify-rc-source-python-macos-arm64 GitHub Actions

@AlenkaF
Copy link
Member Author

AlenkaF commented Mar 20, 2026

@github-actions crossbow submit verify-rc-source-python-macos-amd64

@github-actions
Copy link

Revision: 9ba4a76

Submitted crossbow builds: ursacomputing/crossbow @ actions-109f022a4d

Task Status
verify-rc-source-python-macos-amd64 GitHub Actions

@AlenkaF
Copy link
Member Author

AlenkaF commented Mar 23, 2026

verify-rc-source-python-macos-arm64 failure seems to be connected to #49569, but verify-rc-source-python-macos-amd64 is failing due to:

arrow/dev/release/verify-release-candidate.sh: line 537: 70649 Bus error: 10              python -c "import pyarrow.flight"

cc @raulcd for ideas? (can't test locally, my chip is arm)

@raulcd raulcd force-pushed the gh-49566-cython-headers branch from 9ba4a76 to 3f0f110 Compare March 24, 2026 10:18
@raulcd
Copy link
Member

raulcd commented Mar 24, 2026

@github-actions crossbow submit verify-rc-source-python-macos-amd64 verify-rc-source-python-macos-arm64

@raulcd
Copy link
Member

raulcd commented Mar 24, 2026

@AlenkaF I've rebased main (the macOS arm64 should be fixed there, just validating now) and have pushed a new commit because I think the verification wasn't correct. Is not using the built virtualenv/conda env. I am unsure what the macOS Intel failure is but the reason doesn't seem to be the same one as the one for the other failures so we might want to tackle that one on a separate issue.

@github-actions
Copy link

Revision: 3f0f110

Submitted crossbow builds: ursacomputing/crossbow @ actions-b16e795f8d

Task Status
verify-rc-source-python-macos-amd64 GitHub Actions
verify-rc-source-python-macos-arm64 GitHub Actions

@AlenkaF
Copy link
Member Author

AlenkaF commented Mar 24, 2026

Python 3.14 verification on macos arm is now failing due to:

pip._vendor.pyproject_hooks._impl.BackendUnavailable: Cannot import '_build_backend'

update: both builds have the same, above, issue now 👍

@raulcd
Copy link
Member

raulcd commented Mar 24, 2026

@github-actions crossbow submit verify-rc-source-python-macos-amd64 verify-rc-source-python-macos-arm64

@github-actions
Copy link

Revision: f7d1f9b

Submitted crossbow builds: ursacomputing/crossbow @ actions-eb246d1d18

Task Status
verify-rc-source-python-macos-amd64 GitHub Actions
verify-rc-source-python-macos-arm64 GitHub Actions

@raulcd
Copy link
Member

raulcd commented Mar 24, 2026

@github-actions crossbow submit verify-rc-source-python-macos-amd64

@github-actions
Copy link

Revision: b865cd5

Submitted crossbow builds: ursacomputing/crossbow @ actions-9b5afd26a7

Task Status
verify-rc-source-python-macos-amd64 GitHub Actions

@raulcd
Copy link
Member

raulcd commented Mar 24, 2026

@github-actions crossbow submit verify-rc-source-python-macos-amd64

@github-actions
Copy link

Revision: 3ec70f6

Submitted crossbow builds: ursacomputing/crossbow @ actions-aad2e8bd9a

Task Status
verify-rc-source-python-macos-amd64 GitHub Actions

@raulcd
Copy link
Member

raulcd commented Mar 24, 2026

@github-actions crossbow submit verify-rc-source-python-macos-amd64

@github-actions
Copy link

Revision: 8918219

Submitted crossbow builds: ursacomputing/crossbow @ actions-6df01d3341

Task Status
verify-rc-source-python-macos-amd64 GitHub Actions

@raulcd
Copy link
Member

raulcd commented Mar 24, 2026

@github-actions crossbow submit verify-rc-source-python-macos-amd64 verify-rc-source-python-macos-arm64

@github-actions
Copy link

Revision: 9ef21fd

Submitted crossbow builds: ursacomputing/crossbow @ actions-c945e24f25

Task Status
verify-rc-source-python-macos-amd64 GitHub Actions
verify-rc-source-python-macos-arm64 GitHub Actions

@raulcd
Copy link
Member

raulcd commented Mar 24, 2026

@github-actions crossbow submit verify-rc-source-python-macos-amd64

@github-actions
Copy link

Revision: 5f8c18c

Submitted crossbow builds: ursacomputing/crossbow @ actions-e5fbc461ef

Task Status
verify-rc-source-python-macos-amd64 GitHub Actions

@raulcd
Copy link
Member

raulcd commented Mar 24, 2026

@github-actions crossbow submit verify-rc-source-python-macos-amd64

@github-actions
Copy link

502 Server Error
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/23509011623

@raulcd
Copy link
Member

raulcd commented Mar 24, 2026

@github-actions crossbow submit verify-rc-source-python-macos-amd64

@github-actions
Copy link

Revision: a5ff56d

Submitted crossbow builds: ursacomputing/crossbow @ actions-0c439b7c1c

Task Status
verify-rc-source-python-macos-amd64 GitHub Actions

fi
if [ "${ARROW_FLIGHT}" == "ON" ]; then
python -c "import pyarrow.flight"
python -c "
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
python -c "
python -c "

@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting review Awaiting review labels Mar 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants