GH-49566: [Python] Skip header files when installing compiled Cython files#49571
GH-49566: [Python] Skip header files when installing compiled Cython files#49571AlenkaF wants to merge 11 commits intoapache:mainfrom
Conversation
|
|
|
@github-actions crossbow submit verify-rc-source-python-* |
|
Revision: 719eaf2 Submitted crossbow builds: ursacomputing/crossbow @ actions-3593c891fd |
|
macOS failure are unrelated, I am trying to find a fix, the issue tracking them is this one: |
|
We have a different issue now: _____________________________ test_pyarrow_include _____________________________
def test_pyarrow_include():
# We need to make sure that pyarrow/include is always
# created. Either with PyArrow C++ header files or with
# Arrow C++ and PyArrow C++ header files together
source = os.path.dirname(os.path.abspath(__file__))
pyarrow_dir = pjoin(source, '..')
pyarrow_include = pjoin(pyarrow_dir, 'include')
pyarrow_cpp_include = pjoin(pyarrow_include, 'arrow', 'python')
> assert os.path.exists(pyarrow_include)
E AssertionError: assert False
E + where False = <function exists at 0x7ff433ef9e80>('/arrow/python/pyarrow/tests/../include')
E + where <function exists at 0x7ff433ef9e80> = <module 'posixpath' (frozen)>.exists
E + where <module 'posixpath' (frozen)> = os.pathInvestigating ... |
|
@github-actions crossbow submit verify-rc-source-python-* |
|
Revision: 9ba4a76 Submitted crossbow builds: ursacomputing/crossbow @ actions-7e817c381a |
|
Another issue I need to investigate: |
|
@github-actions crossbow submit verify-rc-source-python-macos-arm64 |
|
Testing if it is a flaky macos issue ... |
|
Revision: 9ba4a76 Submitted crossbow builds: ursacomputing/crossbow @ actions-49b32e9b3a
|
|
@github-actions crossbow submit verify-rc-source-python-macos-amd64 |
|
Revision: 9ba4a76 Submitted crossbow builds: ursacomputing/crossbow @ actions-109f022a4d
|
|
cc @raulcd for ideas? (can't test locally, my chip is arm) |
9ba4a76 to
3f0f110
Compare
|
@github-actions crossbow submit verify-rc-source-python-macos-amd64 verify-rc-source-python-macos-arm64 |
|
@AlenkaF I've rebased main (the macOS arm64 should be fixed there, just validating now) and have pushed a new commit because I think the verification wasn't correct. Is not using the built virtualenv/conda env. I am unsure what the macOS Intel failure is but the reason doesn't seem to be the same one as the one for the other failures so we might want to tackle that one on a separate issue. |
|
Revision: 3f0f110 Submitted crossbow builds: ursacomputing/crossbow @ actions-b16e795f8d
|
|
Python 3.14 verification on macos arm is now failing due to: update: both builds have the same, above, issue now 👍 |
|
@github-actions crossbow submit verify-rc-source-python-macos-amd64 verify-rc-source-python-macos-arm64 |
|
Revision: f7d1f9b Submitted crossbow builds: ursacomputing/crossbow @ actions-eb246d1d18
|
|
@github-actions crossbow submit verify-rc-source-python-macos-amd64 |
|
Revision: b865cd5 Submitted crossbow builds: ursacomputing/crossbow @ actions-9b5afd26a7
|
|
@github-actions crossbow submit verify-rc-source-python-macos-amd64 |
|
Revision: 3ec70f6 Submitted crossbow builds: ursacomputing/crossbow @ actions-aad2e8bd9a
|
|
@github-actions crossbow submit verify-rc-source-python-macos-amd64 |
|
Revision: 8918219 Submitted crossbow builds: ursacomputing/crossbow @ actions-6df01d3341
|
|
@github-actions crossbow submit verify-rc-source-python-macos-amd64 verify-rc-source-python-macos-arm64 |
|
Revision: 9ef21fd Submitted crossbow builds: ursacomputing/crossbow @ actions-c945e24f25
|
|
@github-actions crossbow submit verify-rc-source-python-macos-amd64 |
|
Revision: 5f8c18c Submitted crossbow builds: ursacomputing/crossbow @ actions-e5fbc461ef
|
|
@github-actions crossbow submit verify-rc-source-python-macos-amd64 |
|
|
@github-actions crossbow submit verify-rc-source-python-macos-amd64 |
|
Revision: a5ff56d Submitted crossbow builds: ursacomputing/crossbow @ actions-0c439b7c1c
|
| fi | ||
| if [ "${ARROW_FLIGHT}" == "ON" ]; then | ||
| python -c "import pyarrow.flight" | ||
| python -c " |
There was a problem hiding this comment.
| python -c " | |
| python -c " |
Rationale for this change
Local import is broken when doing editable install with scikit-build-core, also nightly verification jobs are failing for the same reason.
What changes are included in this PR?
lib.handlib_api.hare already installed separately so we skip them when installing Cython extensions into the output destination (side-packages/pyarrow).Are these changes tested?
Yes, locally and via the extended verification builds.
Are there any user-facing changes?
No.